Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotated heatmap figure factory fixes and improvements #1151

Merged
merged 1 commit into from
Sep 2, 2018
Merged

Conversation

jonmmease
Copy link
Contributor

  • Fix map object not subscriptable error Annotated Heatmap with custom color scale raises ValueError #1122 (This happened on Python 3 when specifying a custom colormap using rgb colors)
  • Use colorscale validator to validate specified colorscale (and produce helpful error message) before trying to do text color inference.
  • Handle case where some colors are specified as rgb and some as hex.
  • Add 'Cividis" to list of know lighter-to-darker colorscales.

Thanks for bring this up @andy-lz!

 - Fix `map object not subscriptable` error (This happened on Python 3 when specifying a custom colormap using `rgb` colors)
 - Use colorscale validator to validate specified colorscale before trying to do text color inference.
 - Handle case where some colors are specified as rgb and some as hex.
 - Add 'Cividis" to list of know lighter-to-darker colorscales.
@jonmmease jonmmease added this to the v3.2.0 milestone Sep 1, 2018
@jonmmease jonmmease merged commit 96ade26 into master Sep 2, 2018
@nicolaskruchten nicolaskruchten deleted the bug_1122 branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant